Prevent an exception with large num_retries. #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the calculated wait time is infinite, don't try to do further calculations on it to prevent it from becoming NaN. This could happen if num_retries becomes too large (>1024).
| @@ -401,7 +401,7 @@ def calc_retry_wait | |||
| # secondary retry | |||
| @retry_wait * (2 ** (@num_errors - 2 - @retry_limit)) | |||
| end | |||
| retry_wait = wait + (rand * (wait / 4.0) - (wait / 8.0)) | |||
| retry_wait = wait.infinite? ? wait : wait + (rand * (wait / 4.0) - (wait / 8.0)) | |||
There was a problem hiding this comment.
How about wait.finite? ? wait + (rand * (wait / 4.0) - (wait / 8.0)) : wait ?
finite? covers nan and infinity.
repeatedly
added a commit
that referenced
this pull request
Dec 10, 2014
Prevent an exception with large num_retries.
|
Good catch! |
repeatedly
added a commit
that referenced
this pull request
Dec 10, 2014
Prevent an exception with large num_retries.
|
cherry-picked to v0.10 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the calculated wait time is infinite, don't try to do
further calculations on it to prevent it from becoming NaN.
This could happen if num_retries becomes too large (>1024).
Fixes issue #501