Refix subsection merging rule #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f9d61a.
* to allow overwriting options of config_section and config_params by subclasses * to allow overwrite behavior by 3rd party plugins inherits built-in plugins
…ten for important sections * default is false, to make plugin authors to be able to overwrite super class's behavior
|
@sonots please review this changes |
|
Deployed this to our shadow servers. Are working fluently so far. |
|
Test passed and it seems OK for me. |
|
Looked codes carefully, and LGTM. Since it is working fine as shyouhei-san says, let me merge this. |
|
cherry-picked to v0.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#582 shows that #571 breaks compatibility of existing 3rd party plugins.
This pull-request does:
finaloption to specify sections not to be overwritten3rd party plugins should be able to overwrite super-class's behavior. But some should prohibit overwriting by sub classes. Ex:
<buffer>.Plugin authors should specify
final: truefor these sections.