feat(fluent-bit): Added support for ingress.annotations tpl rendering and image pull policy change

[rgaduput]

• Closes [fluent-bit] values rendering support for ingress.annotations #475
• Closes [fluent-bit] Image pull policy is set to Always by default. #478

[stevehipwell]

Given that annotations are a known type why not use the following simple pattern?

{{- with .Values.ingress.annotations }}
  annotations:
  {{- range $key, $value := . }}
    {{ printf "%s: %s" $key ((tpl $value $) | quote) }}
  {{- end }}
{{- end }}

[rgaduput]

@stevehipwell the idea was to create tpl function which will support any input type and it can be reused in the chart if required. any case , i have pushed your suggestion.
Thanks.

[stevehipwell]

Thanks for making the changes @rgarcia6520, but the pattern still isn't quite right so i've added another suggestion. You will also need to update Chart.yaml with a new version and the release annotations before I can run the tests.

Could you also confirm that you've tested this locally with the values you're planning on using?

[rgaduput]

@stevehipwell thanks, I have implemented your suggestion along with the Chart.yaml changes.
Yes i did the local tests, and it works as expected.

[stevehipwell]

Thanks @rgaduput this PR looks good, but I think it might be worth adding the change from #479 before it's approved/merged to limit the number of chart releases.

[rgaduput]

@stevehipwell done, both are combined in this PR now.

[rgaduput]

closes: #478

[stevehipwell]

LGTM

[stevehipwell]

@patrick-stephens do you know why GH Actions might not be working correctly here? I've not seen a blip on the status page and all of the other repos I'm currently interacting with are fine.

[patrick-stephens]

Just checking on mobile and I can't see any issue, What's the problem?

[stevehipwell]

@patrick-stephens it just hung for a reasonable period, I wasn't sure if there was an org issue or not. Looks like it was just another distributed system consistency issue (AKA undocumented failure).

[stevehipwell]

@patrick-stephens it actually looks like it is org based (the chart release action is also waiting), I suspect the GitHub shard Fluent is on is having runner availability issues.