Add posibility to assign ExternalIPs to fluentbit's Service #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscartrullols
requested review from
edsiper,
naseemkullah and
stevehipwell
as code owners
stevehipwell
requested changes
May 7, 2024
There was a problem hiding this comment.
Thanks for the PR @oscartrullols . Could you update the chart changelog annotations please.
oscartrullols
force-pushed
the
add-externalIPs
branch
from
0265dbd
to
e2838aa
Compare
|
Sorry I wasn't familiar with these |
Signed-off-by: Oscar Trullols <otrullols@nearbycomputing.com>
oscartrullols
force-pushed
the
add-externalIPs
branch
from
5415ddd
to
f26b478
Compare
captainpro-eng
pushed a commit
to captainpro-eng/helm-charts
that referenced
this pull request
May 15, 2024
Signed-off-by: Oscar Trullols <otrullols@nearbycomputing.com> Conflict in UIDs of Grafana dashboard when running multiple Fluent Bit Helm Release. Conflict in UIDs of Grafana dashboard when running multiple Fluent Bit Helm Release. Conflict in UIDs of Grafana dashboard when running multiple Fluent Bit Helm Release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the fluentbit Service with ExternalIPs, if any is defined.
I've followed same pattern many other charts are already using.
Small update but might be helpful to others as well.