Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add api extensions #13

Merged

Conversation

SoftwareWizard
Copy link

extend VirtualFileResultAssertions
extend PhysicalFileResultAssertions
implement CreatedAtRouteResultAssertions
implement CreatedAtActionResultAssertions
implement AcceptedAtRouteResultAssertions
implement AcceptedAtActionResultAssertions
implement LocalRedirectResultAssertions
implement SignIntResultAssertions
implement SignOutResultAssertions
implement UnauthorizedResultAssertions
implement NotFoundResultAssertions
implement NoContentResultAssertions
implement ForbidResultAssertions
implement AcceptedResultAssertions
implement ChallengeResultAssertions
implement CreatedResultAssertions
implement BadRequestResultAssertions
implement OkObjectResultAssertions
implement OkResultAssertions

@kevinkuszyk
Copy link
Member

@SoftwareWizard apologies for the delay in reviewing this - i've been a bit busy with the covid-19 response at the NHS here in the UK over the past couple of weeks.

I try and have a look over the weekend.

@SoftwareWizard
Copy link
Author

SoftwareWizard commented Apr 9, 2020 via email

@faddiv
Copy link
Collaborator

faddiv commented Apr 11, 2020

Hy @SoftwareWizard,

Previously I also added some new stuff and I'm planned to add more, but wow you plowed through these features like a king. Nice work! :)
I also looked into your work and I would like to ask a few question. I reference the code I ask about.

@faddiv
Copy link
Collaborator

faddiv commented Apr 11, 2020

I put my questions in the code.
And thanks for correcting my mistakes in the code. I didn't even noticed since the web project I working on is postponed and I hadn't had the change to try it out.

@kevinkuszyk
Copy link
Member

@SoftwareWizard thanks for bearing with me.

I'm a little out of the loop with all things MVC these days. Thanks for the contribution - there's a lot there.

@SoftwareWizard @faddiv have you finished your discussion and are you both happy with the changes as is? If yes, I'll merge and ship it.

@SoftwareWizard
Copy link
Author

SoftwareWizard commented Apr 21, 2020 via email

@faddiv
Copy link
Collaborator

faddiv commented Apr 24, 2020

I'm also happy with the changes and I will send my improvements after the merge.

@kevinkuszyk kevinkuszyk merged commit d74c8b6 into fluentassertions:master Apr 27, 2020
@kevinkuszyk
Copy link
Member

@SoftwareWizard @faddiv thanks - it's in 2.4 which should be up on nuget shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants