-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error messages improvements #14
Conversation
…ionResult replaced with context.
…ectToRouteAssertions messages.
# Conflicts: # src/FluentAssertions.AspNetCore.Mvc/ActionResultAssertions.cs # src/FluentAssertions.AspNetCore.Mvc/FailureMessages.Designer.cs # src/FluentAssertions.AspNetCore.Mvc/FailureMessages.resx # src/FluentAssertions.AspNetCore.Mvc/PhysicalFileResultAssertions.cs # src/FluentAssertions.AspNetCore.Mvc/VirtualFileResultAssertions.cs # tests/FluentAssertions.AspNetCore.Mvc.Tests/PhysicalFileResultAssertions_Tests.cs # tests/FluentAssertions.AspNetCore.Mvc.Tests/VirtualFileResultAssertions_Tests.cs
… ContainsItem body.
…ates static value.
…ract Reason args everywhere.
@SoftwareWizard I would like to ask about one of your improvement: The WithAuthenticationProperties method, which is on several Assertions, checks the property by reference not by equivalence. Is this intentional? If yes then these error messages should be improved more. |
Oh I almost forgot:
|
@SoftwareWizard do these changes look ok to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kevin,
thanks for your improvements.
Looks good so far for me.
@faddiv @SoftwareWizard thanks for this. I have to admit, I just scanned through the changes, but nothing bad caught my eye. |
Hy Kevin,
At last, I'm finished with my error messages improvements. :)
I also put several other improvements in the code. Here is the list:
Example for "Improved error messages":
Expected ActionResult to be "JsonResult", but found "ViewResult" -> Expected result to be of type Microsoft.AspNetCore.Mvc.JsonResult but was Microsoft.AspNetCore.Mvc.ViewResult.
Expected "Value" to be of type '"String"' but was '"Int32"' -> Expected JsonResult.Value to be of type System.String but was System.Int32.