update package to new version and framework #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinkuszyk Would you be able to take a look at this? |
|
@RyadaProductions thanks for the contribution. We were missing an Also, one little nit - I like to keep dependency versions as low as possible in libs, so that we don't force consumers to upgrade. With that in mind, can you drop the FA dependency down to 5.0 and ninject to 3.3? Once that's done, I'm happy to merge and I'll ship it as version 1.5. |
|
I have Adjusted the dependencies accordingly. |
|
@RyadaProductions thanks again for the contribution. It's in 1.5.0 which should show up on nuget shortly. |
This was referenced Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following things:
Let me know if there are any concerns regarding this PR and I will happily improve it or give feedback on them.