Improve error messages for Be validation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldkroon
changed the title
|
@dennisdoomen do you have time to look at this? |
|
Agreed with @dennisdoomen to:
|
|
Changed as per agreement, please have a look, @dennisdoomen. |
dennisdoomen
approved these changes
Dec 12, 2017
Remove (Not)BeEquivalent validation, because the checks where similar to the Be validation. [BREAKING CHANGE]
ronaldkroon
force-pushed
the
ImproveBeValidation
branch
from
89402eb
to
7a06e14
Compare
dennisdoomen
added a commit
that referenced
this pull request
Jan 13, 2018
Reintroduced #13 in the 5.0 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Be and BeEquivalentTo validations were very similar. Kept the BeEquivalentTo and removed the Be, because the first one has a better name; it shouldn't be the same object, but an equivalent object.
[BREAKING CHANGE]
The error message now specifies the path in the JSON and the type of the first found difference.
Also added an overload that accepts and parses a string representation of a JSON document. Without the overload a string would implicitly be converted to a JValue and compared as such, which is rarely what you want. To use that behavior an explicit JValue must be created. [BREAKING CHANGE]