Improve error messages for ContainSubtree #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also require strict order for elements in an array when checking subtree
jnyrup
reviewed
Feb 28, 2020
jnyrup
approved these changes
Mar 2, 2020
dennisdoomen
approved these changes
Mar 3, 2020
Good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
ContainSubtreewould just reporingsome elements were missing, which is not very informative. Now the same logic and messages fromBeEquivalentToare reused, except that extra properties on the SUT are ignored.When comparing arrays, elements that have a match are skipped for the consecutive elements to compare. Which means that element that are expected multiple times, should really appear multiple times in the SUT, and also the order becomes important.