Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul the infrastructure #62

Merged
merged 11 commits into from
Feb 25, 2022
Merged

Conversation

jnyrup
Copy link
Member

@jnyrup jnyrup commented Feb 25, 2022

This PR brings FluentAssertions.Json all the love that FluentAssertions have had in terms of editorconfig, analyzers, code coverage, etc.

The PR is split up into a commit per feature.

TODO:

6.0.0 from nuget.org
image

this PR
image

Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a beautiful piece of work. I was thinking the exact thing this morning, but lucky for me, you took it upon yourself.

@jnyrup
Copy link
Member Author

jnyrup commented Feb 25, 2022

Hmm... shouldn't the addition of .github/workflows/build.yml have triggered a build?
Seems .github/ needs to be already present for actions to kick in

@jnyrup jnyrup merged commit 3f466e3 into fluentassertions:master Feb 25, 2022
@jnyrup jnyrup deleted the infrastructure branch February 25, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants