Make JTokenDifferentiator an instance class
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
commented
Feb 26, 2022
| @@ -74,7 +82,7 @@ private static Difference CompareExpectedItems(JArray actual, JArray expected, J | |||
| bool match = false; | |||
| for (int actualIndex = matchingIndex; actualIndex < actualChildren.Length; actualIndex++) | |||
| { | |||
| var difference = FindFirstDifference(actualChildren[actualIndex], expectedChild, true, config); | |||
There was a problem hiding this comment.
CompareExpectedItems is only called when ignoreExtraProperties is true, so the three true literals in this method always corresponds to the value of ignoreExtraProperties.
| @@ -117,8 +124,7 @@ private static Difference CompareExpectedItems(JArray actual, JArray expected, J | |||
|
|
|||
| for (int i = 0; i < actualChildren.Length; i++) | |||
| { | |||
| Difference firstDifference = FindFirstDifference(actualChildren[i], expectedChildren[i], | |||
| path.AddIndex(i), false, config); | |||
There was a problem hiding this comment.
CompareItems is only called when ignoreExtraProperties is false.
Pull Request Test Coverage Report for Build 1903789818
💛 - Coveralls |
dennisdoomen
approved these changes
Feb 26, 2022
jnyrup
force-pushed
the
JTokenDifferentiator
branch
from
d35d92a
to
e9e4310
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
JTokenDifferentiatoran instance class to reduce the number of arguments passed around.