-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed BeEquivalentTo
when using a custom comparer targeting nullable types
#2648
Fixed BeEquivalentTo
when using a custom comparer targeting nullable types
#2648
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 9224869081Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. In addition to the comments from @IT-VBFK, I have nothing more to add than a suggestion
e3aa155
to
21ecef5
Compare
21ecef5
to
5dddcda
Compare
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
The way the
EqualityComparerEquivalencyStep<T>
step is comparing the comparand's type against the equality comparer's type has been reviewed to take into account nullables.This fixes #2595.
IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome