Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XElement .Should().Be() gives false positives. #3

Closed
dennisdoomen opened this issue Aug 24, 2013 · 5 comments
Closed

XElement .Should().Be() gives false positives. #3

dennisdoomen opened this issue Aug 24, 2013 · 5 comments
Labels

Comments

@dennisdoomen
Copy link
Member

See original CodePlex issue.

@dennisdoomen
Copy link
Member Author

A proper solution is proposed in http://blogs.msdn.com/b/ericwhite/archive/2009/01/28/equality-semantics-of-linq-to-xml-trees.aspx. I've asked Eric White for permission.

@dennisdoomen
Copy link
Member Author

We got approval from Eric. https://twitter.com/EricWhiteDev/status/449486245236711424

@adamvoss
Copy link
Contributor

Thanks for asking Eric! I wasn't finding an e-mail address and don't use Twitter myself. There is a snag though. The Microsoft Limited Public License has the restriction that its grants are restricted to to works that run on Windows. I would need to read the full text of the Apache License to see if it is compatible (I doubt it); but even it it is, this would be a problem for the Xamarin folks.

Do you think he might be able to re-license under the Microsoft Limited Public License? That is certainly compatible for the binary distribution. At the source level that may force FA to license under the MSPL as well (It is not entirely clear to me if we can distribute a single-file licensed differently than the rest of the project or if the project would need to be re-license). Of course the least hassle would be if he could license under the Apache License (though BSD or MIT would also work).

@dennisdoomen dennisdoomen added this to the Release 3.0 milestone Mar 29, 2014
@dennisdoomen
Copy link
Member Author

After discussion with @vossad01, I'm going to implement the normalized comparison through the Should().BeEquivalent() method to prevent confusion with the current behavior.

@dennisdoomen dennisdoomen modified the milestones: Release 3.1, Release 3.0 Apr 21, 2014
@dennisdoomen dennisdoomen modified the milestones: Release 3.1, Release 3.2 Jul 12, 2014
@dennisdoomen dennisdoomen modified the milestones: v3.3, v3.2 Sep 9, 2014
@dennisdoomen dennisdoomen modified the milestones: v3.4, v3.3 Dec 22, 2014
@dennisdoomen dennisdoomen removed this from the v3.4 milestone Apr 15, 2015
@dennisdoomen
Copy link
Member Author

Duplicate of #354.

adamvoss pushed a commit to adamvoss/fluentassertions that referenced this issue Apr 1, 2017
* Use config.yml FA repo links
* Add `repository` config value (required to run locally)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants