Consistency in Attribute assertions

[jnyrup]

If #727 gets merged, we should also revise other calls to
GetCustomAttributes(bool inherit) and
GetCustomAttributes(Type attributeType, bool inherit)

E.g TypeSelector,ThatAreDecoratedWith currently calls GetCustomAttributes(typeof(TAttribute), true) which would be inconsistent with the difference between BeDecoratedWith and BeDecoratedWithOrInherit.

[jnyrup]

@dennisdoomen in TypeExtensions.cs we are inconsistent whether we use HasAttribute or IsDecoratedWith and whether inherited attributes are considered.

The only other API methods that have Attribute in their name are the HaveAttribute methods from XElementAssertions and XmlElementAssertions.

The current API methods are:

bool HasAttribute<TAttribute>(this MemberInfo method);
bool HasMatchingAttribute<TAttribute>(this MemberInfo type, Expression<Func<TAttribute, bool>> isMatchingAttributePredicate);
bool HasMatchingAttribute<TAttribute>(this Type type, Expression<Func<TAttribute, bool>> isMatchingAttributePredicate, bool inherit = false);
bool IsDecoratedWith<TAttribute>(this MemberInfo type);
bool IsDecoratedWith<TAttribute>(this Type type, bool inherit = false);

HasMatchingAttribute<TAttribute>(this MemberInfo type, Expression<Func<TAttribute, bool>> isMatchingAttributePredicate)
--> `GetCustomAttributes<TAttribute>(MemberInfo type)`
--> type.GetCustomAttributes(false).OfType<TAttribute>()

but

public static bool HasAttribute<TAttribute>(this MemberInfo method)
--> method.GetCustomAttributes(typeof(TAttribute), true)

If it's not too late to change, I propose the following API:

IsDecoratedWith(this Type type)
IsDecoratedWith(this TypeInfo type)
IsDecoratedWith(this MemberInfo type)

IsDecoratedWithOrInherits(this Type type)
IsDecoratedWithOrInherits(this TypeInfo type)
IsDecoratedWithOrInherits(this MemberInfo type)

IsDecoratedWith(this Type type, Expression<Func<TAttribute, bool>> isMatchingAttributePredicate)
IsDecoratedWith(this TypeInfo type, Expression<Func<TAttribute, bool>> isMatchingAttributePredicate)
IsDecoratedWith(this MemberInfo type, Expression<Func<TAttribute, bool>> isMatchingAttributePredicate)

IsDecoratedWithOrInherits(this Type type, Expression<Func<TAttribute, bool>> isMatchingAttributePredicate)
IsDecoratedWithOrInherits(this TypeInfo type, Expression<Func<TAttribute, bool>> isMatchingAttributePredicate)
IsDecoratedWithOrInherits(this MemberInfo type, Expression<Func<TAttribute, bool>> isMatchingAttributePredicate)

This should make the API consistent and remove the optional booleans from the API.

[Evangelink]

@dennisdoomen, @jnyrup, are you expecting some help (see help wanted label) to implement the suggested API or to discuss about the API?

[dennisdoomen]

To implement it ;-)