Redundant BindingFlags

[jnyrup]

From TypeExtensions.cs

private const BindingFlags PublicMembersFlag =
BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance;

private const BindingFlags AllMembersFlag =
PublicMembersFlag | BindingFlags.NonPublic | BindingFlags.Static;

Note how BindingFlags.NonPublic is included in both constants.

Is that just redundant?

[dennisdoomen]

No, that can be removed.

[jnyrup]

Come again?

[dennisdoomen]

I mean the duplicate BindingFlags.NonPublic

[jnyrup]

I just wondered since

private static IEnumerable<PropertyInfo> GetPublicProperties(Type type)
{
    return type.GetProperties(PublicMembersFlag);
}

uses PublicMembersFlag, which includes BindingFlags.NonPublic, and hence GetPublicProperties will also return private properties.

[dennisdoomen]

Sure. Just remove it.