Support chaining NotThrowAfter and NotThrowAsync
#1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
approved these changes
Mar 29, 2020
Tests/FluentAssertions.Specs/Specialized/TaskOfTAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
Tests/FluentAssertions.Specs/Specialized/TaskOfTAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
jnyrup
force-pushed
the
FuncTaskT
branch
2 times, most recently
from
45dac8d
to
b2afe1f
Compare
|
Updated PR with more widespread changes. |
This PR enables you to continue asserting on the result of `Func<Task<int>>` when it does not throw.
```c#
Func<Task<int>> func = () => Task.FromResult(42);
func.Should().NotThrow()
.Which.Should().Be(42);
(await func.Should().NotThrowAsync())
.Which.Should().Be(42);
func.Should().NotThrowAfter(10.Seconds(), 1.Seconds())
.Which.Should().Be(42)
(await func.Should().NotThrowAfterAsync(10.Seconds(), 1.Seconds()))
.Which.Should().Be(42);
```
The implementations and tests are mostly copied from the non-generic or sync versions.
To avoid the redefinitions of `Subject` in each class two changes in generics:
* `DelegateAssertions` and `AsyncFunctionAssertions` are now generic in `TAssertions`.
* `AsyncFunctionAssertions` is also generic in `TTask : Task` to support
both `Task` and `Task<T>` equally.
This fixes fluentassertions#990
|
@dennisdoomen this should be ready for (another) review now. In continuation of #1296 I've added more generics:
|
dennisdoomen
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables you to continue asserting on the result of
Func<Task<int>>when it does not throw.The implementations and tests are mostly copied from the non-generic or sync versions.
To avoid the redefinitions of
Subjectin each class two changes in generics:DelegateAssertionsandAsyncFunctionAssertionsare now generic inTAssertions.AsyncFunctionAssertionsis also generic inTTask : Taskto supportboth
TaskandTask<T>equally.This fixes #990