-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add several new methods to Types and Methods Assertions #1306
Conversation
@jnyrup @dennisdoomen, hi there |
Sorry, completely missed this one. Will take a look tomorrow. |
Tests/FluentAssertions.Specs/Types/MethodInfoSelectorAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
Tests/FluentAssertions.Specs/Types/MethodInfoSelectorAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
Sorry, I meant to click the "Request Changes" button.
You can run Oh, and would you also be willing to update the docs and release notes under |
Sure. it's a pleasure for me to make a contribution to such a nice library :) |
I've described new Can you also instruct me about release notes? Should it be described as I need more time to add tests for And the last one, I would be grateful if you instruct me about the need to rebase all these changes to a single commit since there are a lot of them now. |
Looks good to me.
It's all going to be part of 6.0.0. Just add it under the "new" section.
If you have not "designed" your PR as clean separated commits, will just squash-merge your changes. I myself follow a pretty rigorous practice to get a clean source control history. |
Well, as far as I can see, everything is done :) But the build is broken for some reason not related to my changes, as I can see. Could you please look what’s the matter for it? |
Co-Authored-By: Jonas Nyrup <jnyrup@users.noreply.github.com>
Co-Authored-By: Jonas Nyrup <jnyrup@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the feeling every time I get to digest a PR, to become more comfortable with it, and we together file of the rough edges to get a polished result ❤️
Co-Authored-By: Jonas Nyrup <jnyrup@users.noreply.github.com>
@fshchudlo Thanks for the contribution! |
@jnyrup I'm sure this is my first contribution, but not the last :) Thank you for such a thorough study of PR and such a cool library :) |
Hello there.
I've added a couple of methods to types selectors and assertions which, I hope, you find useful.
Corresponding unit tests, of course, added.
Approval tests are definitely broken since I've added new methods, but I'm not sure if I should change them since they are approval tests. I would be grateful if you instruct me on this
IMPORTANT