-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataSet Collections: ContainItemWithName #1893
DataSet Collections: ContainItemWithName #1893
Conversation
…rtionExtensions.cs and DataColumnCollectionAssertionExtensions.cs and corresponding tests in DataTableCollectionAssertionExtensionsSpecs.cs and DataColumnCollectionAssertionExtensionsSpecs.cs. Reran AcceptApiChanges.ps1. Updated releases.md to describe this change. Updated data.md to describe this functionality.
Also please move the API discussion to an issue. |
API proposal discussion issue: #1897 |
As discussed in #1897, we decided not to make this API part of the library. |
If I wanted to make my own extension library and make this a part of it, I would run into the problem that the code needs to identify the type
Thanks :-) |
I can't think of any other way then just making that wrapper public. You can submit a PR for that if you want |
Alright, will do. Thanks :-) |
|
I was pulling from the wrong upstream. 🤦♂️ |
This PR adds functionality on top of the
DataSet
assertions which was originally written for #1812 but which got moved out for its own independent pull request/evaluation. The changes apply toDataTableCollection
andDataColumnCollection
, which have elements that are logically named, and include unit tests and documentation.IMPORTANT