Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for .NET Core #2302

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Drop support for .NET Core #2302

merged 1 commit into from
Sep 20, 2023

Conversation

dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Sep 17, 2023 •
edited

Given we don't want to shrink the API surface for frameworks supported by Microsoft, this PR reduces the supported frameworks to .NET Framework 4.7, .NET 6.0, .NET Standard 2.0 (because of UWP) and .NET Standard (because of Mono, Xamarin and Unity).

We also decided to no longer test .NET Standard. The biggest risk is that we use something that compiles but doesn't work in Unity, UWP and such. Testing this with other frameworks like the unsupported .NET Core isn't going to help. We could have embraced Unity, UWP and such. But that would require quite some infrastructure, not just for us, but also for our contributors.

Closes #2251

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Sep 17, 2023 •
edited

Qodana for .NET

29 new problems were found

Inspection name Severity Problems
Redundant using directive 🔶 Warning 20
Unused parameter (private accessibility) 🔶 Warning 4
Type member is never used (private accessibility) 🔶 Warning 2
Similar anonymous type detected nearby ◽️ Notice 2
Convert delegate variable into local function ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Sep 17, 2023 •
edited

Pull Request Test Coverage Report for Build 6231864167

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.255%
Totals Coverage Status
Change from base Build 6213336064: 0.01%
Covered Lines: 11624
Relevant Lines: 11830
💛 - Coveralls

@jnyrup jnyrup mentioned this pull request Sep 17, 2023
Closed
@dennisdoomen dennisdoomen force-pushed the Refactor/NetTargets branch 3 times, most recently from ddaa58f to 99c31e7 Compare September 17, 2023 19:03
@dennisdoomen dennisdoomen marked this pull request as ready for review September 17, 2023 19:03
@dennisdoomen
Copy link
Member Author

I'm confused about the Qodana issues. They seem to be false positives.

jnyrup
jnyrup approved these changes Sep 19, 2023
View reviewed changes
docs/_pages/about.md
Comment on lines 44 to 49
Because of that Fluent Assertions supports the following minimum platforms.

* .NET Core 2.1 and 3.0
* .NET Framework 4.7 and later
* .NET 6.0 and later
* Mono 5.4, Xamarin.iOS 10.14, Xamarin.Mac 3.8 and Xamarin.Android 8.0
* Universal Windows Platform 10.0.16299 and later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 We can still run on .NET Core 2.0 and above

"Because of that Fluent Assertions can run on the following minimum platforms."

@jnyrup
Copy link
Member

jnyrup commented Sep 19, 2023

I'm confused about the Qodana issues. They seem to be false positives.

Which ones?

@dennisdoomen
Copy link
Member Author

Which ones?

https://github.com/fluentassertions/fluentassertions/pull/2302/checks?check_run_id=16914456719

@dennisdoomen dennisdoomen merged commit a07bdfd into fluentassertions:develop Sep 20, 2023
3 of 5 checks passed
@dennisdoomen dennisdoomen deleted the Refactor/NetTargets branch September 20, 2023 05:39
@dennisdoomen
Copy link
Member Author

I've reported at least two false positives to JetBrains and will also issue a separate PR to tweak the settings a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-VBFK IT-VBFK IT-VBFK left review comments

@jnyrup jnyrup jnyrup approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit .NET targets
4 participants
@dennisdoomen @coveralls @jnyrup @IT-VBFK