-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address various Qodana issues to bring the threshold back to 0 #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
dennisdoomen
force-pushed
the
Refactor/AddressQodanaIssues
branch
from
January 13, 2024 12:57
d4300c4
to
4330ef2
Compare
Pull Request Test Coverage Report for Build 7525437519
💛 - Coveralls |
jnyrup
reviewed
Jan 14, 2024
Src/FluentAssertions/Formatting/MultidimensionalArrayFormatter.cs
Outdated
Show resolved
Hide resolved
Tests/FluentAssertions.Specs/Primitives/ObjectAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
jnyrup
reviewed
Jan 14, 2024
We had to disable RCS1055 to prevent Roslyn from complaining about missing semicolons.
dennisdoomen
force-pushed
the
Refactor/AddressQodanaIssues
branch
from
January 15, 2024 07:04
4330ef2
to
2e1f1b4
Compare
jnyrup
approved these changes
Jan 15, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to Reviewer commit-by-commit.
Since PRs cannot be used to verify the net affect, check out https://github.com/fluentassertions/fluentassertions/actions/runs/7512592573
IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome