Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address various Qodana issues to bring the threshold back to 0 #2553

Merged
merged 7 commits into from Jan 15, 2024

Conversation

dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Jan 13, 2024

Note to Reviewer commit-by-commit.

Since PRs cannot be used to verify the net affect, check out https://github.com/fluentassertions/fluentassertions/actions/runs/7512592573

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

Copy link

github-actions bot commented Jan 13, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Jan 13, 2024

Pull Request Test Coverage Report for Build 7525437519

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.463%

Totals Coverage Status
Change from base Build 7520600368: 0.0%
Covered Lines: 11945
Relevant Lines: 12130

💛 - Coveralls

Tests/.editorconfig Outdated Show resolved Hide resolved
@dennisdoomen dennisdoomen merged commit 8c5045c into develop Jan 15, 2024
10 checks passed
@dennisdoomen dennisdoomen deleted the Refactor/AddressQodanaIssues branch January 15, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants