Simplify InternalsVisibleTo PublicKey

[WeihanLi]

Use the PublicKey MSBuild property to simplify the PublicKey configuration

https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#internalsvisibleto

In addition to #2300

IMPORTANT

• If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
• The code complies with the Coding Guidelines for C#.
• The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
• If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
• If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
• If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

[github-actions]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[coveralls]

Pull Request Test Coverage Report for Build 7708828146

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.463%

---

Totals
Change from base Build 7707766295:	0.0%
Covered Lines:	11945
Relevant Lines:	12130

---

💛 - Coveralls

[jnyrup]

Does this change anything in the produced dll/nupkg?

[WeihanLi]

Does this change anything in the produced dll/nupkg?

It should remain the same as before, would just try to add the PublicKey info from the MSBuild property

[WeihanLi]

https://nuget.info/packages/FluentAssertions/6.12.0 net6.0 dll info

new built dll info with pr changes(built with dotnet build -c Release)

[jnyrup]

I searched to see if defining <PublicKey> would have other effects, but at least I couldn't find any.

And found the implementing PR of this feature: dotnet/sdk#3439