Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [StringSyntax("CompositeFormat")] to all "because" parameters #2635

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

psychotoad
Copy link

@psychotoad psychotoad commented May 7, 2024

Implements #2630

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8991881228

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.561%

Totals Coverage Status
Change from base Build 8882705409: 0.0%
Covered Lines: 12026
Relevant Lines: 12210

💛 - Coveralls

Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the Qodana scan failed.

@dennisdoomen dennisdoomen requested a review from jnyrup May 10, 2024 17:16
@psychotoad
Copy link
Author

I don't really understand what is wrong or what I am supposed to do.

@dennisdoomen
Copy link
Member

I don't really understand what is wrong or what I am supposed to do.

It doesn't seem to be related to your changes. We're investigating it.

@ITaluone
Copy link
Contributor

@psychotoad try rebase onto current develop and force push

@dennisdoomen
Copy link
Member

It doesn't seem to be related to your changes. We're investigating it.

It is caused by Qodana. JetBrains is working on a fix already.

Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
If you search for these two regexes, I found ~30 more more places to add it.

  • [\(,][ \r\n]*string [a-zA-Z]+,[ \r\n]+(params )?object\[
  • [\(,][ \r\n]*string because

Except MessageBuilder.Build (as it may contain {reason}), IAssertionScope.WithExpectation, IAssertionScope.FailWith and their implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants