New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [StringSyntax("CompositeFormat")] to all "because" parameters #2635
base: develop
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 8991881228Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the Qodana scan failed.
I don't really understand what is wrong or what I am supposed to do. |
It doesn't seem to be related to your changes. We're investigating it. |
@psychotoad try rebase onto current develop and force push |
It is caused by Qodana. JetBrains is working on a fix already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
If you search for these two regexes, I found ~30 more more places to add it.
[\(,][ \r\n]*string [a-zA-Z]+,[ \r\n]+(params )?object\[
[\(,][ \r\n]*string because
Except MessageBuilder.Build
(as it may contain {reason}
), IAssertionScope.WithExpectation
, IAssertionScope.FailWith
and their implementations
Implements #2630
IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome