Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scoped value formatters #2676

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Add scoped value formatters #2676

merged 5 commits into from
Jul 8, 2024

Conversation

ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Jun 18, 2024 •
edited
Loading

Closes: #2478

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9565943493

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12103
Relevant Lines: 12286
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9566134362

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12103
Relevant Lines: 12286
💛 - Coveralls

@ITaluone ITaluone mentioned this pull request Jun 19, 2024
Closed
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch 2 times, most recently from 1082f19 to 9bd75b8 Compare June 20, 2024 07:26
@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9593231468

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12103
Relevant Lines: 12286
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9593346015

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12103
Relevant Lines: 12286
💛 - Coveralls

@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 9bd75b8 to f929234 Compare June 20, 2024 09:04
@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9594672423

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 1e8834b to 50b1f2c Compare June 23, 2024 10:41
@coveralls
Copy link

coveralls commented Jun 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9632815207

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9632826420

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9550728512: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

dennisdoomen
dennisdoomen requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. I mostly have minor suggestions that would make the PR even better.

Tests/FluentAssertions.Specs/Execution/AssertionScope.ScopedFormatters.cs Outdated Show resolved Hide resolved
Src/FluentAssertions/Execution/AssertionScope.cs Outdated Show resolved Hide resolved
docs/_pages/introduction.md Show resolved Hide resolved
docs/_pages/introduction.md Outdated Show resolved Hide resolved
docs/_pages/introduction.md Outdated Show resolved Hide resolved
docs/_pages/releases.md Outdated Show resolved Hide resolved
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 4cfa82b to 81796df Compare June 25, 2024 20:01
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 81796df to 6523752 Compare June 25, 2024 20:05
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9668772806

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9664182752: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9668821122

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9664182752: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9668876071

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.581%
Totals Coverage Status
Change from base Build 9664182752: 0.003%
Covered Lines: 12100
Relevant Lines: 12283
💛 - Coveralls

dennisdoomen
dennisdoomen approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dennisdoomen dennisdoomen requested a review from jnyrup June 26, 2024 05:21
@ITaluone ITaluone mentioned this pull request Jun 26, 2024
Closed
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 6523752 to fe217ea Compare June 27, 2024 14:43
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9698700015

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.677%
Totals Coverage Status
Change from base Build 9698432905: 0.003%
Covered Lines: 12102
Relevant Lines: 12276
💛 - Coveralls

@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from fe217ea to 6bf0046 Compare July 1, 2024 12:44
@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9744452616

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.714%
Totals Coverage Status
Change from base Build 9722382730: 0.002%
Covered Lines: 12102
Relevant Lines: 12276
💛 - Coveralls

jnyrup
jnyrup reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review just by reading the changes.
As this combines formatters on different levels (static and instance), I'd like to open this up in my IDE to have a deeper look.

We have previously had different bugs for assertion scopes,
e.g. #2329, #2318 and #2044 so we should triple check that we not re-introducing race conditions when e.g. modifying custom formatters on a inner scope while also having statically defined formatters.

Possibly related, #2619 is a case where we didn't consider that a functionality would be added to the shared static context and hence must be thread-safe when executing tests in parallel.

Src/FluentAssertions/Formatting/Formatter.cs Outdated Show resolved Hide resolved
Tests/FluentAssertions.Specs/Execution/AssertionScope.ScopedFormatters.cs Show resolved Hide resolved
Src/FluentAssertions/Formatting/FormattingOptions.cs Show resolved Hide resolved
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch 3 times, most recently from 1124aa0 to 7c63e1c Compare July 4, 2024 05:56
@ITaluone ITaluone requested a review from jnyrup July 4, 2024 05:56
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from 7c63e1c to f9ba153 Compare July 4, 2024 05:59
@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9789169633

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.713%
Totals Coverage Status
Change from base Build 9764328235: 0.001%
Covered Lines: 12097
Relevant Lines: 12271
💛 - Coveralls

@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch 2 times, most recently from fda7d9a to f27cc39 Compare July 4, 2024 06:08
ITaluone and others added 5 commits July 4, 2024 08:18
@ITaluone
Add scoped formatters
baeac77
@ITaluone
Accept API changes
bc1bf62
@ITaluone @dennisdoomen
Update releases
d66a34f 
Co-authored-by: Dennis Doomen <dennis.doomen@avivasolutions.nl>
@ITaluone @dennisdoomen
Add documentation
1692df3 
Co-authored-by: Dennis Doomen <dennis.doomen@avivasolutions.nl>
@ITaluone @IT-VBFK
Fix xml documentation
5efc728 
Co-authored-by: IT-VBFK <49762557+IT-VBFK@users.noreply.github.com>
@ITaluone ITaluone force-pushed the feat/scoped-value-formatters branch from f27cc39 to 5efc728 Compare July 4, 2024 06:18
@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9789460304

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.713%
Totals Coverage Status
Change from base Build 9764328235: 0.001%
Covered Lines: 12097
Relevant Lines: 12271
💛 - Coveralls

@jnyrup jnyrup merged commit e2d09bf into fluentassertions:develop Jul 8, 2024
7 checks passed
@ITaluone ITaluone deleted the feat/scoped-value-formatters branch July 8, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-VBFK IT-VBFK IT-VBFK left review comments

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scoped value formatters
5 participants
@ITaluone @coveralls @dennisdoomen @jnyrup @IT-VBFK