Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage in ...Formatters #2679

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Jun 20, 2024

TaskFormatter

Removed unreachable path.
I think we can rely on the return value of CanHandle() that we are dealing with a Task.
I tried to get into the Format method using Formatter.Format((Task)null), but I always ended up in the NullFormatter.

GuidValueFormatter / StringValueFormatter

An interpolated string has no missed branches for whatever reason.

FormatterObjectGraph

Removed an unused method, which was introduced in #2144

DateTimeOffsetValueFormatter

Since we first check in HasTime that the value also could have milli seconds, the if branch can never be entered

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

Copy link

github-actions bot commented Jun 20, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9596727311

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.596%

Totals Coverage Status
Change from base Build 9550728512: 0.02%
Covered Lines: 12087
Relevant Lines: 12268

💛 - Coveralls

@ITaluone ITaluone changed the title Improve code coverage in TaskFormatter Improve code coverage in ...Formatters Jun 20, 2024
@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9597487678

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 97.608%

Totals Coverage Status
Change from base Build 9550728512: 0.03%
Covered Lines: 12087
Relevant Lines: 12268

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9598743264

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 97.663%

Totals Coverage Status
Change from base Build 9550728512: 0.09%
Covered Lines: 12089
Relevant Lines: 12264

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 22, 2024

Pull Request Test Coverage Report for Build 9623296749

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 97.663%

Totals Coverage Status
Change from base Build 9550728512: 0.09%
Covered Lines: 12089
Relevant Lines: 12264

💛 - Coveralls

@ITaluone ITaluone requested a review from jnyrup June 25, 2024 09:57
@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9660674713

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 97.674%

Totals Coverage Status
Change from base Build 9550728512: 0.1%
Covered Lines: 12088
Relevant Lines: 12262

💛 - Coveralls

@jnyrup jnyrup merged commit df63edf into fluentassertions:develop Jun 27, 2024
7 checks passed
@ITaluone ITaluone deleted the codecov/taskformatter branch June 27, 2024 14:40
@dennisdoomen dennisdoomen added the testing Testing of Fluent Assertion itself label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing of Fluent Assertion itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants