-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage in ...Formatter
s
#2679
Merged
jnyrup
merged 5 commits into
fluentassertions:develop
from
ITaluone:codecov/taskformatter
Jun 27, 2024
Merged
Improve code coverage in ...Formatter
s
#2679
jnyrup
merged 5 commits into
fluentassertions:develop
from
ITaluone:codecov/taskformatter
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITaluone
force-pushed
the
codecov/taskformatter
branch
from
June 20, 2024 11:36
20cade9
to
4260822
Compare
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 9596727311Details
💛 - Coveralls |
ITaluone
changed the title
Improve code coverage in
Improve code coverage in Jun 20, 2024
TaskFormatter
...Formatter
s
Pull Request Test Coverage Report for Build 9597487678Details
💛 - Coveralls |
ITaluone
force-pushed
the
codecov/taskformatter
branch
from
June 20, 2024 13:53
d327435
to
a36bb56
Compare
Pull Request Test Coverage Report for Build 9598743264Details
💛 - Coveralls |
jnyrup
reviewed
Jun 21, 2024
ITaluone
force-pushed
the
codecov/taskformatter
branch
from
June 22, 2024 05:46
a36bb56
to
debd62f
Compare
Pull Request Test Coverage Report for Build 9623296749Details
💛 - Coveralls |
dennisdoomen
approved these changes
Jun 22, 2024
Pull Request Test Coverage Report for Build 9660674713Details
💛 - Coveralls |
ITaluone
commented
Jun 25, 2024
jnyrup
reviewed
Jun 25, 2024
dennisdoomen
approved these changes
Jun 25, 2024
jnyrup
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskFormatter
Removed unreachable path.
I think we can rely on the return value of
CanHandle()
that we are dealing with aTask
.I tried to get into the
Format
method usingFormatter.Format((Task)null)
, but I always ended up in theNullFormatter
.GuidValueFormatter
/StringValueFormatter
An interpolated string has no missed branches for whatever reason.
FormatterObjectGraph
Removed an unused method, which was introduced in #2144
DateTimeOffsetValueFormatter
Since we first check in
HasTime
that the value also could have milli seconds, theif
branch can never be enteredIMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome