Assuming types that override Equals to have value semantics #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
changed the title
dennisdoomen
force-pushed
the
DetectValueSemantics
branch
from
941f8be
to
3687871
Compare
jnyrup
reviewed
Jan 25, 2018
dennisdoomen
force-pushed
the
DetectValueSemantics
branch
4 times, most recently
from
4d5032f
to
7c08e11
Compare
Replaced all mechanisms and options to control whether or not an object has value semantics by a single algorithm. Any object that overrides object.Equals and is not an anonymous type or tuple is treated as a value type, unless ComparingByMembers<T>() is used. Also removes the global AssertionOptions.IsValueType
dennisdoomen
force-pushed
the
DetectValueSemantics
branch
from
7c08e11
to
a648696
Compare
dennisdoomen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all mechanisms and options to control whether or not an object has value semantics by a single algorithm: Any object that overrides object.Equals and is not an anonymous type is treated as a value type, unless ComparingByMembers() is used. Also removes the global AssertionOptions.IsValueType. For those cases where this algorithm misbehaves, ComparingByValue can be used.
#739