Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes
Equal
for generic collections as #490 mentioned performance problems.The slowdown was mostly due generic collections of value types being boxed.
A minor downside is that now the subject will now be enumerated twice when failing, whereas before it was a copy of the subject that got enumerated in
EnumerableValueFormatter
.I believe this is worthwhile as we should optimize for tests passing.
In the benchmark:
CollectionEqual_NonGeneric
is equivalent to the current behavior,CollectionEqual_Generic
is the optimized version from this PR.CollectionEqual_Generic_Equality
is using a custom comparer in the benchmark,(int s, int e) => s == e
in this example.