Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags not working correctly with runner in 3.2.4 #1211

Closed
mmiller678 opened this issue Apr 9, 2020 · 2 comments
Closed

Tags not working correctly with runner in 3.2.4 #1211

mmiller678 opened this issue Apr 9, 2020 · 2 comments
Assignees
Labels
cannot-reproduce Cannot reproduce the problem

Comments

@mmiller678
Copy link

The runner is complaining that no migrations exist when a tag is specified. I think is because its only picking up migrations with that tag, rather than migrations with the tag + migrations without any tags.

Exception

While executing migrations the following error was encountered: No migrations found,    at FluentMigrator.Runner.DefaultMigrationInformationLoader.FindMigrations(IMigrationSource source, IMigrationRunnerConventions conventions, String namespace, Boolean loadNestedNamespaces, String[] tagsToMatch, Boolean includeUntagged) in /home/travis/build/fluentmigrator/fluentmigra
tor/src/FluentMigrator.Runner/DefaultMigrationInformationLoader.cs:line 185 [D:\Source\Panda\trunk\build.targets]
D:\Source\Panda\trunk\Tools\packages\Weiss.MSBuild.1.2.54.1137\content\Weiss.Core.targets(91,5): error :    at FluentMigrator.Runner.DefaultMigrationInformationLoader.LoadMigrations() in /home/travis/build/fluentmigrator/fluentmigrator/src/FluentMigrator.Runner/DefaultMigrationInformationLoader.cs:line 126 [D:\Source\Panda\trunk\build.targets]
@mmiller678 mmiller678 changed the title Tags not working correct in 3.2.4 Tags not working correctly with runner in 3.2.4 Apr 9, 2020
jzabroski added a commit to jzabroski/fluentmigrator that referenced this issue Apr 10, 2020
@jzabroski
Copy link
Collaborator

I think this is a false positive. This can happen is you run FluentMigrator.MSBuild 3.2.1 task with an assembly referencing FluentMigrator 3.2.4 nuget package.

I played around with reproducing the issue here: #1211

The only way, in my judgment, this can happen, is if the wrong assembly version is loaded. Why it fails this way is a bit beyond me at the moment (midnight). I will follow up with more, tomorrow maybe.

@mmiller678
Copy link
Author

Agreed - this was a mistake on my part. We can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cannot-reproduce Cannot reproduce the problem
Projects
None yet
Development

No branches or pull requests

2 participants