Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: RunnerOptions.IncludeUntaggedMaintenanceMigratrions will now default to true #1689

Closed
jzabroski opened this issue Nov 25, 2023 · 3 comments
Milestone

Comments

@jzabroski
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
See #1062, #1607, #1591

Describe the solution you'd like
To make the default behavior of fluent migrator to include untagged maintenance migrations, consistent with untagged migrations. This legacy behavior has caused a lot of confusion.

@jzabroski jzabroski added this to the 5.0.0 milestone Nov 25, 2023
jzabroski added a commit that referenced this issue Nov 25, 2023
@rhegner
Copy link

rhegner commented Jan 18, 2024

Could you please provide an example of such an "untagged maintenance migration"?

I've been using fluentmigrator for a long time, but based on this pretty short description I'm not sure if/how this breaking change is affecting my codebase.

@jzabroski
Copy link
Collaborator Author

jzabroski commented Jan 18, 2024

Great question.

[Maintenance(Stage.AfterAll)]
//Tags("NonProduction")] // uncommenting this would make it a tagged migration 
public SetUpNonProductionTestDependencies : Migration
{
    public void Up() 
    {
        // code
    }
}

Let me know if it's not clear.

In general, it seems a lot of people were thrown off by this behavior, and it makes configuring Dependency Injection harder and less intuitive. I thought about refactoring the whole way we handled maintenence migrations, but I realized the simplest fix is to just make the overall approach consistent between regular migrations and maintenance migrations.

@rhegner
Copy link

rhegner commented Jan 18, 2024

Thanks for the quick response (and for this great library)!
It is clear now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants