Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using index algorithm #1366

Merged
merged 5 commits into from
Nov 23, 2020

Conversation

lillo42
Copy link
Contributor

@lillo42 lillo42 commented Oct 29, 2020

Add support for using index algorithm:

  • BTree
  • Hash
  • Gist
  • Spgist
  • Gin
  • Brin

@jzabroski
Copy link
Collaborator

This looks great, but I don't see (and was expecting to see) a PostgresExtensions with a signature that let's you pass in the Enum? Am I just being blind looking at the PR on GitHub and I don't see that interface?

Basically, I see .UsingBtreeAlgorithm(), etc, but I dont see .Using(Algorithm.Btree). The rationale for letting people pass in an enum is it is easier to parameterize. One use case would be to demo the differences in performances between two index methodologies. Another use case would be to allow people to use FluentMigrator as a dynamic tooling API to generate scripts from within a GUI.

Rename enum
Rename Method removing Algorithm suffix
@jzabroski
Copy link
Collaborator

This pr is fine. I will merge this weekend

@jzabroski jzabroski merged commit 906156d into fluentmigrator:master Nov 23, 2020
@lillo42 lillo42 deleted the add-support-index-algorithm branch November 26, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants