Replace crlf with Environment.Newline #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tforms, add additional tests to not working on Mono
|
@schambers This PR is marked as a draft, but it looks like all the tests passed. Are there additional places its failing on Mono not visible here in the Checks tab? |
|
@jzabroski I was just waiting until today to mark it as good. Everything should be good with this. I'll mark it as ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all locations in FluentMigrator.Runner were properly using Environment.Newline. This was causing tests to fail on osx.
This also includes more Category annotations that can be ignored when running tests on Mono. These failures are likely due to unicode character encoding and Shouldly not able to properly compare strings
Fixes #1751