Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#612 Update Oracle TypeMap #613

Merged
merged 3 commits into from Jun 20, 2015

Conversation

jonnybee
Copy link

@jonnybee jonnybee commented Jun 4, 2015

Updated Oracle typemap as per Oracle documentation:
https://docs.oracle.com/cd/B28359_01/server.111/b28320/limits001.htm#i287903

CHAR - max 2000
NCHAR - max 2000
VARCHAR2 - max 4000
NVARCHAR2 - max 4000
RAW - max 2000

@tommarien
Copy link
Contributor

@jonnybee could you add tests for the typemap, you can make OracleTypeMap public if needed ;)

Thanks

@jonnybee
Copy link
Author

Unit tests for OracleTypeMap has been added to PR.

@tommarien
Copy link
Contributor

@jonnybee Thanks, just a remark though, don't test the constants test the typemapping itself, does not matter if the constants have the correct value. What matters if that for certain criteria the typemapping switches accordingly ;)

@tommarien
Copy link
Contributor

@jonnybee Also wondering about RAW(max) should it not be just

Raw up until 2000 bytes
BLOB for beyond ?

@jonnybee
Copy link
Author

Yes, you are correct. RAW(MAX) is not a valid datatype.
RAW is up to 2000- and if more then BLOB.

I have updated the typemap and unit tests.

@tommarien tommarien added this to the vNext milestone Jun 11, 2015
@tommarien tommarien added the bug label Jun 11, 2015
@tommarien tommarien merged commit 749a842 into fluentmigrator:master Jun 20, 2015
@tommarien
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants