Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usage of BorderThickness, ResizeBorderThickness and GlassBorderThickness #209

Closed
batzen opened this issue Dec 8, 2015 · 0 comments

Comments

@batzen
Copy link
Member

batzen commented Dec 8, 2015

Currently BorderThickness, ResizeBorderThickness and GlassBorderThickness are used inconsistently.

First step will be a rename from GlassBorderThickness to GlassFrameThickness to make it clear that it does not control a Border but the GlassFrame instead.

After that the usage of ResizeBorderThickness should be removed, except for controlling the WindowChromeBehavior.

The parts of RibbonWindow which currently use ResizeBorderThickness should be changed to use BorderThickness (or something else) instead.

Because we are currently using this in a wrong way the Office 2010 and Window 8 themes look kind of awkward on Windows 10 currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant