Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curious why MP support was removed? #56

Closed
lemmy101 opened this issue Jan 18, 2024 · 0 comments
Closed

Curious why MP support was removed? #56

lemmy101 opened this issue Jan 18, 2024 · 0 comments

Comments

@lemmy101
Copy link

lemmy101 commented Jan 18, 2024

I've been working on multiplayer support on MP Compat as I simply can't handle using the vanilla research tree on modded playthroughs, and it was suggested when I did a PR that I try a PR for this project directly as it's still supported, and when going to add SyncMethod into some of the Queue methods I was surprised to see a commented out SyncMethod attribute already present, and as it turns out my solution was very similar to an older commit that seems to have been long commented out since.

Was wondering why this was reverted, if there was any issues discovered with SyncMethods for the queue and a SyncWorker to handle ResearchNodes that haven't become apparent in hours of my testing. In my experience its made the research tree perfectly usable in MP.

Thanks!

@lemmy101 lemmy101 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
@zube zube bot closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant