Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 support added #169

Closed
wants to merge 1 commit into from
Closed

PHP 8 support added #169

wants to merge 1 commit into from

Conversation

Ahmard
Copy link

@Ahmard Ahmard commented Dec 7, 2020

PHP 8 support added
\InvalidArgumentException class imported
Some PHPDoc updated

PHP 8 support added
7399a85 
\InvalidArgumentException class imported
Some PHPDoc updated
acabutto
acabutto reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@acabutto acabutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manage to "composer update" the repo using php 8.0? Looks that fzaninotto/faker has been abandoned and is not compatible with php 8.0

@Ahmard
Copy link
Author

Ahmard commented Dec 7, 2020

PHP 8 is the default version my machine is running on, so I silenced platform requirement checks.
Thank you for figuring it out.

@Ahmard Ahmard closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acabutto acabutto acabutto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ahmard @acabutto