Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Node labels exceeds maximum length limit for long namespace and name #704

Closed
2sin18 opened this issue Apr 12, 2021 · 1 comment
Closed
Labels
bug Something isn't working
Projects

Comments

@2sin18
Copy link
Contributor

2sin18 commented Apr 12, 2021

What is your environment(Kubernetes version, Fluid version, etc.)

Kubernetes version: 1.18
Fluid version: 0.6.0

Describe the bug
Label name and values in Kubernetes has a maximum length limit of 63 characters as request by RFC-1123. However, Fluid adds labels to nodes with long prefix (see below examples), which limits the total length of namespace and name of datasets to 63 - 41 = 22.

data.fluid.io/storage-human-jindo-disk-{namespace}-{name}=1B,
data.fluid.io/storage-human-jindo-total-{namespace}-{name}=1B,
data.fluid.io/storage-jindo-{namespace}-{name}=true,
data.fluid.io/storage-{namespace}-{name}=true,
fluid_exclusive={namespace}_{name},

What you expect to happen:

Reduce length of node label prefix.

How to reproduce it

Create a dataset with namespace and name that exceeds 22 characters.

Additional Information

None.

@2sin18 2sin18 added the bug Something isn't working label Apr 12, 2021
@cheyang
Copy link
Collaborator

cheyang commented Apr 12, 2021

fixed by #696

@cheyang cheyang closed this as completed Apr 12, 2021
@cheyang cheyang added this to To do in v0.6.0 via automation Apr 12, 2021
@cheyang cheyang moved this from To do to Done in v0.6.0 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants