Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor label name to reduce the length of label #696

Merged
merged 5 commits into from
Apr 10, 2021

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Apr 9, 2021

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cheyang cheyang requested a review from frankleaf April 9, 2021 04:12
@codecov-io
Copy link

Codecov Report

Merging #696 (e8f4cd9) into master (96d8cf1) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   16.81%   16.81%           
=======================================
  Files          67       67           
  Lines        2943     2943           
=======================================
  Hits          495      495           
  Misses       2397     2397           
  Partials       51       51           
Impacted Files Coverage Δ
pkg/ddc/alluxio/label.go 10.00% <ø> (ø)
pkg/ddc/alluxio/shutdown.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d8cf1...e8f4cd9. Read the comment docs.

pkg/ddc/alluxio/label.go Outdated Show resolved Hide resolved
pkg/common/constants.go Outdated Show resolved Hide resolved
cheyang and others added 3 commits April 9, 2021 18:37
Co-authored-by: TzZtzt <rt@porpoise.name>
Co-authored-by: TzZtzt <rt@porpoise.name>
Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang merged commit 054bb42 into fluid-cloudnative:master Apr 10, 2021
@cheyang cheyang deleted the refine_node_label branch April 18, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants