update resource/privileged of juicefs #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2130 +/- ##
==========================================
- Coverage 52.72% 52.69% -0.03%
==========================================
Files 298 298
Lines 21726 21712 -14
==========================================
- Hits 11454 11442 -12
+ Misses 9048 9043 -5
- Partials 1224 1227 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pkg/ddc/juicefs/type.go
Outdated
| @@ -54,6 +54,7 @@ type Configs struct { | |||
| } | |||
|
|
|||
| type Worker struct { | |||
| NotPrivileged bool `yaml:"notPrivileged,omitempty"` | |||
There was a problem hiding this comment.
This supposed to be unPrivileged?
There was a problem hiding this comment.
How about using privileged ? unPrivileged is not straight forward.
|
@zwwhdls Please fix DCO for the newest commit. The code lgtm. |
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
zwwhdls
force-pushed
the
update_jfs_for_ask
branch
from
61afeba
to
4a7c949
Compare
cheyang
reviewed
Sep 15, 2022
| @@ -124,8 +124,10 @@ spec: | |||
| - containerPort: 9567 | |||
There was a problem hiding this comment.
Please update 1. chart version 2. change log , so we can keep them on track.
Signed-off-by: zwwhdls <zww@hdls.me>
cheyang
approved these changes
Sep 15, 2022
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Jan 2, 2023
* update resource/privileged of juicefs Signed-off-by: zwwhdls <zww@hdls.me> * fix resource Signed-off-by: zwwhdls <zww@hdls.me> * update changelog of chart & update privileged Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Jan 2, 2023
* update resource/privileged of juicefs Signed-off-by: zwwhdls <zww@hdls.me> * fix resource Signed-off-by: zwwhdls <zww@hdls.me> * update changelog of chart & update privileged Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com>
cheyang
added a commit
that referenced
this pull request
Jan 2, 2023
* update resource/privileged of juicefs Signed-off-by: zwwhdls <zww@hdls.me> * fix resource Signed-off-by: zwwhdls <zww@hdls.me> * update changelog of chart & update privileged Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> Co-authored-by: Weiwei <zww@hdls.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zwwhdls zww@hdls.me
Ⅰ. Describe what this PR does
make privileged and resource of juicefs worker setable
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews