fix cacheHits query & remove liveness probe of juicefs worker #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zwwhdls <zww@hdls.me>
Codecov Report
@@ Coverage Diff @@
## master #2212 +/- ##
==========================================
- Coverage 51.36% 51.35% -0.02%
==========================================
Files 331 331
Lines 24293 24302 +9
==========================================
+ Hits 12479 12480 +1
- Misses 10421 10425 +4
- Partials 1393 1397 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cheyang
reviewed
Oct 24, 2022
| pods, err := j.GetRunningPodsOfDaemonset(stsName, j.namespace) | ||
| if err != nil || len(pods) == 0 { | ||
| return | ||
| var containerName string |
There was a problem hiding this comment.
Would you add some unit tests?
Signed-off-by: zwwhdls <zww@hdls.me>
cheyang
approved these changes
Oct 24, 2022
Yanghaihai1020
pushed a commit
to Yanghaihai1020/fluid
that referenced
this pull request
Oct 31, 2022
…cloudnative#2212) * fix cacheHits query & remove liveness probe of juicefs worker Signed-off-by: zwwhdls <zww@hdls.me> * add unittest Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: yn <yanghaihai690@163.com>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Jan 3, 2023
…cloudnative#2212) * fix cacheHits query & remove liveness probe of juicefs worker Signed-off-by: zwwhdls <zww@hdls.me> * add unittest Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Jan 3, 2023
…cloudnative#2212) * fix cacheHits query & remove liveness probe of juicefs worker Signed-off-by: zwwhdls <zww@hdls.me> * add unittest Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com>
cheyang
added a commit
that referenced
this pull request
Jan 3, 2023
* fix privileged configuration (#2137) Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * delete juicefs dataload privileged (#2153) Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * add juicefs diagnose script and fix alluxio diagnose script (#2156) * add juicefs diagnose script and fix alluxio diagnose script Signed-off-by: zwwhdls <zww@hdls.me> * rename diagnose script Signed-off-by: zwwhdls <zww@hdls.me> * fix doc Signed-off-by: zwwhdls <zww@hdls.me> * fix doc Signed-off-by: zwwhdls <zww@hdls.me> * fix doc Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * fix runtime replicas is 0 (#2160) Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * fix ro accessMode (#2183) Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * fix juicefs cache capacity (#2186) Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * fix cacheHits query & remove liveness probe of juicefs worker (#2212) * fix cacheHits query & remove liveness probe of juicefs worker Signed-off-by: zwwhdls <zww@hdls.me> * add unittest Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * make worker manage policy parallel (#2237) Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * add juicefs networkmode (#2343) Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * fix juicefs yaml marshal & fix volume mount (#2346) * fix juicefs yaml marshal & fix volume mount Signed-off-by: zwwhdls <zww@hdls.me> * fix yaml marshal in dataload Signed-off-by: zwwhdls <zww@hdls.me> * udpate changelog Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * add updateStrategy for juicefs fuse (#2375) Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> Co-authored-by: Weiwei <zww@hdls.me>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Feb 14, 2023
…cloudnative#2212) * fix cacheHits query & remove liveness probe of juicefs worker Signed-off-by: zwwhdls <zww@hdls.me> * add unittest Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: zwwhdls <zww@hdls.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zwwhdls zww@hdls.me
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews