-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix csi plugin loop mount bug #3287
bugfix: fix csi plugin loop mount bug #3287
Conversation
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3287 +/- ##
=======================================
Coverage 65.48% 65.48%
=======================================
Files 398 398
Lines 23179 23179
=======================================
Hits 15179 15179
Misses 6215 6215
Partials 1785 1785 |
/test fluid-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix CSI node plugin loop mount error Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
* Fix CSI node plugin loop mount error Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Signed-off-by: cheyang <cheyang@163.com>
Ⅰ. Describe what this PR does
This PR fixes #3286, which is caused by looping bind-mounts when Fluid's CSI plugin attempts to mount both
/var/lib/kubelet
(withmountPropagation=Bidirectional
) and/var/lib/kubelet/pki
into the container.This PR fixes this bug by checking if
kubelet-root-dir
is a parent directory ofkubelet-cert-dir
and determine whether to mountkubelet-cert-dir
. This is to avoid looping bind mounts and mount info leak when restarting the Pod.Ⅱ. Does this pull request fix one issue?
fixes #3286
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews