Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default master journal type setting (#3281) #3291

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Jun 14, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cheyang cheyang force-pushed the support_multiple_master_for_alluxio_0.8 branch from 003281c to a2438bd Compare June 14, 2023 06:21
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #3291 (3e1588d) into release-0.8 (2ca41e8) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

❗ Current head 3e1588d differs from pull request most recent head a2438bd. Consider uploading reports for the commit a2438bd to get more accurate results

@@               Coverage Diff               @@
##           release-0.8    #3291      +/-   ##
===============================================
- Coverage        68.30%   68.28%   -0.02%     
===============================================
  Files              297      297              
  Lines            16966    16969       +3     
===============================================
  Hits             11588    11588              
- Misses            4127     4128       +1     
- Partials          1251     1253       +2     
Impacted Files Coverage Δ
pkg/ddc/alluxio/transform_optimization.go 83.87% <25.00%> (-1.66%) ⬇️

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 3cabcf1 into fluid-cloudnative:release-0.8 Jun 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants