Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount kubelet.conf with HostToContainer mount propagation #3318

Merged

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Jun 30, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #3318 (0cae34b) into release-0.8 (3cabcf1) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 0cae34b differs from pull request most recent head 46c5e24. Consider uploading reports for the commit 46c5e24 to get more accurate results

@@               Coverage Diff               @@
##           release-0.8    #3318      +/-   ##
===============================================
- Coverage        68.32%   68.28%   -0.04%     
===============================================
  Files              297      297              
  Lines            16969    16969              
===============================================
- Hits             11594    11588       -6     
- Misses            4125     4128       +3     
- Partials          1250     1253       +3     

see 1 file with indirect coverage changes

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 937441d into fluid-cloudnative:release-0.8 Jul 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants