Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mountinfo to check mountinfo #3351

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Jul 21, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang changed the title Use mountinfo to check mountinfo, To #50179395 Use mountinfo to check mountinfo Jul 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #3351 (1ba9227) into release-0.8 (937441d) will decrease coverage by 0.04%.
The diff coverage is 40.00%.

❗ Current head 1ba9227 differs from pull request most recent head 9d0a326. Consider uploading reports for the commit 9d0a326 to get more accurate results

@@               Coverage Diff               @@
##           release-0.8    #3351      +/-   ##
===============================================
- Coverage        68.28%   68.25%   -0.04%     
===============================================
  Files              297      297              
  Lines            16969    16978       +9     
===============================================
+ Hits             11588    11589       +1     
- Misses            4128     4136       +8     
  Partials          1253     1253              
Impacted Files Coverage Δ
pkg/utils/helm/utils.go 77.31% <40.00%> (-5.42%) ⬇️

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 4706d51 into fluid-cloudnative:release-0.8 Jul 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants