Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick to 0.9: check path existence and lock in NodeUnpublishVolume (#3284) #3450

Conversation

TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

Cherry-pick for PR #3284

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…ve#3284)

* check path existence and lock in NodeUnpublishVolume

Signed-off-by: wangshulin <wangshulin@smail.nju.edu.cn>

* use path level lock and lock for NodePublishVolume

Signed-off-by: wangshulin <wangshulin@smail.nju.edu.cn>

* small fix

Signed-off-by: wangshulin <wangshulin@smail.nju.edu.cn>

* return codes.aborted when the lock is not acquired

Signed-off-by: wangshulin <wangshulin@smail.nju.edu.cn>

* check target path validity

Signed-off-by: wangshulin <wangshulin@smail.nju.edu.cn>

* adjust order of check path and acquire lock

Signed-off-by: wangshulin <wangshulin@smail.nju.edu.cn>

---------

Signed-off-by: wangshulin <wangshulin@smail.nju.edu.cn>
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #3450 (960b985) into release-0.9 (987e6e7) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 960b985 differs from pull request most recent head 950369e. Consider uploading reports for the commit 950369e to get more accurate results

@@               Coverage Diff               @@
##           release-0.9    #3450      +/-   ##
===============================================
- Coverage        65.52%   65.49%   -0.04%     
===============================================
  Files              397      398       +1     
  Lines            23107    23121      +14     
===============================================
  Hits             15142    15142              
- Misses            6183     6197      +14     
  Partials          1782     1782              
Files Changed Coverage Δ
pkg/utils/volume_lock.go 0.00% <0.00%> (ø)

@fluid-e2e-bot fluid-e2e-bot bot merged commit 76e2621 into fluid-cloudnative:release-0.9 Sep 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants