-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect conversion between integer types #3688
Fix incorrect conversion between integer types #3688
Conversation
Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3688 +/- ##
==========================================
- Coverage 64.47% 64.46% -0.01%
==========================================
Files 471 471
Lines 28140 28149 +9
==========================================
+ Hits 18142 18147 +5
- Misses 7844 7847 +3
- Partials 2154 2155 +1 ☔ View full report in Codecov by Sentry. |
/test fluid-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
…tive#3688)" This reverts commit a015ab3.
Ⅰ. Describe what this PR does
This PR fix some incorrect conversions between integer types. In some ddc's operation, the
uint64
type is convert toint64
directly, which may provide unexpected return value.Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Add some unit tests in which the return value is negative.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews