pass AccessModes to thinruntime fuse container #3696
Conversation
Signed-off-by: xliuqq <xlzq1992@gmail.com>
Signed-off-by: xliuqq <xlzq1992@gmail.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3696 +/- ##
=======================================
Coverage 64.46% 64.46%
=======================================
Files 471 471
Lines 28153 28156 +3
=======================================
+ Hits 18149 18152 +3
Misses 7848 7848
Partials 2156 2156 ☔ View full report in Codecov by Sentry. |
| @@ -705,7 +706,7 @@ func TestThinEngine_transformFuseWithDuplicateOptionKey(t1 *testing.T) { | |||
| }}, | |||
| // ConfigValue: "{\"/thin/fluid/test/thin-fuse\":\"a=b\"}", | |||
| // MountPath: "/thin/fluid/test/thin-fuse", | |||
| ConfigValue: "{\"mounts\":[{\"mountPoint\":\"abc\",\"options\":{\"a\":\"b\"}}],\"targetPath\":\"/thin/fluid/test/thin-fuse\"}", | |||
| ConfigValue: "{\"mounts\":[{\"mountPoint\":\"abc\",\"options\":{\"a\":\"b\"}}],\"targetPath\":\"/thin/fluid/test/thin-fuse\",\"accessModes\":[\"ReadOnlyMany\"]}", | |||
There was a problem hiding this comment.
Could you add a test with accessModes as ReadWriteMany?
There was a problem hiding this comment.
see above code line 490, accessModes as ReadWriteMany.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
pass AccessModes to thinruntime fuse container
Ⅱ. Does this pull request fix one issue?
fixes #3636
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews