minorfix: carefully handle pod.namespace to avoid side effect #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
cheyang
reviewed
Jun 19, 2024
cheyang
reviewed
Jun 19, 2024
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cheyang
pushed a commit
to Ametsuji-akiya/fluid
that referenced
this pull request
Jul 16, 2024
…cloudnative#4172) * carefully handle pod.namespace Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * carefully handle pod.namespace Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * carefully handle pod.namespace Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Signed-off-by: cheyang <cheyang@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Follow-up of #4171
#4171 overrides
pod.Namespacewithreq.Namespaceno matter whatpod.Namespaceis. The may have some side effect when mutating a Pod, for example, changing pod.metadata.namespace after mutation. This PR fixes this by checking ifpod.Namespaceis valid and try to revert it before the handler responds.Ⅱ. Does this pull request fix one issue?
None
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews