Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generatePermalink should work if content is not in a language directory #195

Closed
greatislander opened this issue Aug 3, 2023 · 0 comments · Fixed by #196 or #197
Closed

generatePermalink should work if content is not in a language directory #195

greatislander opened this issue Aug 3, 2023 · 0 comments · Fixed by #196 or #197
Assignees
@greatislander
Labels
bug Something isn't working
Milestone
2.3.0

Comments

@greatislander
Copy link
Contributor

Describe the bug

Right now the generatePermalink utility tries to determine the content language:

eleventy-plugin-fluid/src/utils/generate-permalink.js

Line 21 in 9b3f812

const lang = EleventyI18nPlugin.LangUtils.getLanguageCodeFromInputPath(data.page.inputPath);

However, this should be done in directory data files and passed to the helper in the data object so that the generatePermalink utility works even when there is only one (default) language.
@greatislander greatislander added the bug Something isn't working label Aug 3, 2023
@greatislander greatislander self-assigned this Aug 3, 2023
@greatislander greatislander added this to the 2.3.0 milestone Aug 3, 2023
greatislander added a commit that referenced this issue Aug 3, 2023
@greatislander
feat: allow generatePermalink to work for non-localized content (fix #…
cebbfdd 
…195)

feat: allow string translation to be disabled (fix #194)
@greatislander greatislander linked a pull request Aug 3, 2023 that will close this issue
feat: allow generatePermalink to work for unlocalized content (fix #195) #196
Merged
greatislander added a commit that referenced this issue Aug 3, 2023
@greatislander
feat: allow generatePermalink to work for unlocalized content (fix #195…
f1d2376 
…) (#196)

fix: allow generatePermalink to work for unlocalized content (fix #195)
@github-actions github-actions bot mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
None yet
Milestone
2.3.0
1 participant
@greatislander