Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CSS processing configuration (resolves #3) #164

Merged
merged 26 commits into from Jul 11, 2023

Conversation

greatislander
Copy link
Contributor

@greatislander greatislander commented Jul 7, 2023

@greatislander greatislander self-assigned this Jul 7, 2023
@greatislander greatislander added the enhancement New feature or request label Jul 7, 2023
@greatislander greatislander marked this pull request as ready for review July 10, 2023 15:29
Copy link
Member

@jobara jobara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add tests for the following:

  • The deepMerge function
  • Passing custom options to the css through eleventy
  • Subdirectories of css files.

README.md Outdated Show resolved Hide resolved
@greatislander
Copy link
Contributor Author

It would be good to add tests for the following:

  • The deepMerge function
  • Passing custom options to the css through eleventy
  • Subdirectories of css files.

The second one was already addressed in the existing test (overriding the basePath to ./fixtures/assets/styles). I've added both a partial in its own directory and a standalone CSS file in a nested directory and tested to ensure they are handled properly and they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants