Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): skip checkChanges publish dev and standard #6

Closed
wants to merge 1 commit into from

Conversation

ramonornela
Copy link

  • Skip called Publish.checkchanges() to dev and standard this need in case project alter package.json before of publish

@jobara
Copy link
Member

jobara commented Nov 21, 2016

@ramonornela thank you for submitting this pull request. I have a few process related requests for you, in addition to the code review I'll supply.

  1. We require all contributors to sign and return a Contributor License Agreement ( CLA ). Please fill out and return a scan of the document to me. We'll need this to accept your PR. You can find a copy of the CLA on the Fluid Licensing wiki page. If you ping me ( Justin_o ) in the fluid-work IRC channel, I can send you my e-mail address.
  2. I've filed a ticket for the issue you mention here. FLUID-6082. Could you please update your commit log to start with the Issue number e.g. "FLUID-6082: your commit message"

var checkChange = options.checkChanges;
if (checkChange === undefined) {
checkChange = true;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than create the checkChanges variable here and do the if check on undefined, I think you can create a new option in the defaultOptions called something like "allowChanges", and set it to false by default. In addition to updating the unit tests, you should update the README to provide documentation for this feature.

@amb26
Copy link
Member

amb26 commented Apr 17, 2018

Closing due to lack of activity

@amb26 amb26 closed this Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants