GH-246: Add doc for infusion 4.5.0 release and update package dependencies #247
Conversation
| <section class="flc-prefsEditor-separatedPanel fl-prefsEditor-separatedPanel"> | ||
| <!-- | ||
| This div is for the sliding panel bar that shows and hides the Preference Editor controls in the mobile view. | ||
| A separate panel bar for mobile displays is needed to preserver the correct tab order. |
|
|
||
| ### UI Options Template in Infusion 4.5 | ||
|
|
||
| Remove the css selector `flc-prefsEditor-iframe` from the div that will contain the Preference Editor component. |
There was a problem hiding this comment.
I think it might confuse people to only quote the markup which is now obsolete and give them an instruction how to correct it - perhaps better to quote the corrected markup in full?
| @@ -44,7 +44,7 @@ the meaning and form of the context name can vary and have a different meaning i | |||
| <li> | |||
| an entire <code><reference></code> string in itself. This is useful in highly | |||
| dynamic cases where the context name should be determined from some other options | |||
| material, e.g. <code>{{that}.options.targetContext}</code> | |||
| material, e.g. <code>{% raw %}{{that}.options.targetContext}{% endraw %}</code> | |||
There was a problem hiding this comment.
What is the %raw% directive issued against? Does the {{ confuse the markdown processor somehow?
There was a problem hiding this comment.
Yes, exactly. The new version of Eleventy parses strings in double curly brackets as template vars.
| "lunr": "2.3.9", | ||
| "markdown-it-anchor": "8.4.1", | ||
| "octicons": "3.1.0", |
There was a problem hiding this comment.
I'm not sure what the cause is, but I got an error running npm run build or npm run start complaining that markdown-it itself was not installed.
[dev ] [11ty] Eleventy CLI Fatal Error: (more in DEBUG output)
[dev ] [11ty] 1. Error in your Eleventy config file 'E:/source/gits/infusion-docs/.eleventy.js'. You may need to run `npm install`. (via EleventyConfigError)
[dev ] [11ty] 2. Cannot find module 'markdown-it'
Adding the line here:
"markdown-it": "13.0.1",
made the problem go away
| @@ -231,8 +231,8 @@ fluid.defaults("demo.panels.language", { | |||
| protoTree: { | |||
There was a problem hiding this comment.
Not part of this work, but we could correct a typo here on line 63
Preference Maps are **only** required if you are working with
[schemas](PrimarySchemaForPreferencesFramework.md))
there is an extra ) after the link here
|
Good catch, @amb26. All addressed. This pull request is ready for another look. Thanks. |
This pull request does: